[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [patch] commit-email.pl usage message wording corrections

From: <kfogel_at_collab.net>
Date: 2005-12-20 18:10:19 CET

Ryan Schmidt <subversion-2006Q1@ryandesign.com> writes:
> Noticed a couple wording issues in the usage message printed by
> commit-email.pl which I fix in the attached patch.

Thanks, applied in r17886.

Just for future reference, these things would make patch
review/application a bit easier on our end:

   - If attaching the patch, set the mime-type to text/plain, instead
     of application/octet-stream, so we can read it inline.

   - Make it apply relative to the top of a Subversion working copy,
     e.g., the relative path "tools/hook-scripts/commit-email.pl.in".

   - Check the filename :-). The change needed to be made to
     commit-email.pl.in, not commit-email.pl.

   - Use all caps "[PATCH]" in the subject line (the lower case is
     harder to spot, and is not the convention that automated filters
     may be looking for).

   - Send to dev@, not just users@. It's just luck that I happened to
     spot this on users@.

   - A log message would save us a bit of time, though in this case of
     course it was trivial to write it.

Thank you,
-Karl

-- 
www.collab.net  <>  CollabNet  |  Distributed Development On Demand
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Tue Dec 20 20:22:33 2005

This is an archived mail posted to the Subversion Users mailing list.