Re: problem with svnversion -n

On Oct 31, 2005, at 1:48 AM, John Szakmeister wrote:

> On Monday 31 October 2005 03:10, Andrew McIntyre wrote:
>
>> The problem appears to be in svnversion's main.c, line 287.
>> Perhaps:
>> SVN_INT_ERR (svn_cmdline_printf (pool, _("exported\n")));
>> should be:
>> SVN_INT_ERR (svn_cmdline_printf (pool, _((no_newline ?
>> "exported" : "exported\n"))));
>
> What version are you using? I see this the 1.0.x and 1.1.x
> branches, but
> 1.2.x and 1.3.x look fine.

I was looking at version 1.1.4, the version currently in use with
Apache Gump.

>> Similar problem at line 296. Comments? If there's a workaround to
>> suppress the extra newline for exported directories, let me know.
>
> No, it's definitely a bug. However, Jani Averbach fixed it on
> trunk in
> r10987. It looks like it never made it to the 1.0.x and 1.1.x
> branches
> though.
>

Yep, I hadn't checked the 1.2.x code. It is fixed there. Thanks for
the pointer!

> I could not find anything wrong near line 296. The only thing I
> saw was a
> line printing an error to stderr, and the newline is correct in
> that case.

I was referring to:

svn_clear_error (svn_cmdline_fprintf (stderr, pool,
                                   _("'%s' not versioned, and not
exported\n"),
                                   wc_path));

As you suggested, the newline is acceptable in this case since it is
printed to stderr.

Thanks again, I'll recommend upgrading to the 1.2.x line to the Gump
folks.

Cheers,
andrew

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Mon Oct 31 11:09:20 2005