[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: problem with svnversion -n

From: John Szakmeister <john_at_szakmeister.net>
Date: 2005-10-31 10:48:03 CET

On Monday 31 October 2005 03:10, Andrew McIntyre wrote:
> Hi subversion-users:
> Recently Apache Derby hit an unusual problem with svnversion that I
> think may be an svnversion bug. During Apache Gump's build of Derby,
> which contains the Derby source code in a copied directory, Ant
> records the output of 'svnversion -n .' to a file, which is later
> read back in as an Ant property. Because this is not a checked-out
> directory in the gump build, the version is reported as 'exported',
> but with a newline attached.
> Because this is later read back in as the version at which Derby was
> built, and included in the manifest file for the Derby jar files,
> this causes the generation of the Derby manifest file to fail because
> the newline after 'exported' puts a newline into the manifest file in
> an unacceptable location.
> The problem appears to be in svnversion's main.c, line 287.
> Perhaps:
> SVN_INT_ERR (svn_cmdline_printf (pool, _("exported\n")));
> should be:
> SVN_INT_ERR (svn_cmdline_printf (pool, _((no_newline ?
> "exported" : "exported\n"))));

What version are you using? I see this the 1.0.x and 1.1.x branches, but
1.2.x and 1.3.x look fine. There will not be another release on the 1.0.x
line unless a security bug is found, and 1.1.x is quickly approaching that
same point since 1.3.0 is around the corner.

> Similar problem at line 296. Comments? If there's a workaround to
> suppress the extra newline for exported directories, let me know.

No, it's definitely a bug. However, Jani Averbach fixed it on trunk in
r10987. It looks like it never made it to the 1.0.x and 1.1.x branches

I could not find anything wrong near line 296. The only thing I saw was a
line printing an error to stderr, and the newline is correct in that case.

I'd recommend upgrading to 1.2.3 or 1.3.0 (when it becomes available).

Thanks for the report!


To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Mon Oct 31 10:50:12 2005

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.