[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Post Commit Code Formatting

From: Mark Phippard <MarkP_at_softlanding.com>
Date: 2005-06-22 22:06:29 CEST

"Durfee, Bernard" <Bernard.Durfee@suny.edu> wrote on 06/22/2005 03:49:37
PM:

> I guess I didn't get that same message. Thanks for clearing that up. I
> think I now understand the process and am eager to participate.

Great. I would suggest asking the dev@ list what they would like to see
from you in the way of a design. You may even get one or two that would
want to review your design ideas and help formulate them. I imagine it
depends on who has spent time thinking about this.

> > What is the problem? Just because this is a feature you want
> > it is more
> > important than the ones that are currently being worked on?
> > If it isn't
> > implemented immediately the devs are unresponsive?
>
> Like I said before, this issue seems to be a common desire that has been
> lingering for many years. The suggestion is generally shot-down at some
> point as being bad-practice.

I believe that what has been shot-down is the notion that a server-side
pre-commit hook should format the code. I think you would need to propose
a client-side solution. I am not one of the devs though.

> > Ask yourself this, if you were one of the devs, would you
> > want to do this
> > feature now? I wouldn't. Luckily for you, Karl and the
> > other devs don't
> > feel that way.
>
> In fact I think I would like to implement the feature. Why would you not
> want to implement such a useful feature?

I was implying that your comments were not inspiring anyone to want to
implement this feature.

FWIW, I have seen comments in the past that implied that they used a
pre-commit hook to validate that the code met the formatting standards. I
cannot imagine how that hook would be written, but that is anouther issue.
 Anyway, developers had the formatting tools to fix the code and resubmit
the commit. The hook was just to remind them when they forgot. To me,
that seems like a reasonable solution that can be implemented today.

Mark

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Wed Jun 22 22:08:21 2005

This is an archived mail posted to the Subversion Users mailing list.