Bad quoting of URL keywords passed to external diff viewer

I had trouble trying to configure diff pane names in KDiff3 to include
both URL and revision, like %burl@%brev.

For testing, I used the following .bat file contents as a diff viewer:

@echo off
setlocal

echo rev one is %1
echo rev two is %2
echo url one is %3
echo url two is %4
pause

:END
endlocal
echo on

I set up my diff viewer settings to invoke it as follows:

  C:\Temp\test.bat %brev %yrev %burl %yurl

This results in:

rev one is "1796"
rev two is "1797"
url one is "http://example.com/trunk/.project "http://example.com/trunk/.project
url two is "C:\tmp\.project-rev1796.svn007.tmp.project"

Notice that %burl is missing an end quote. I'm not 100% sure it needs
to be quoted at all, but certainly it should have both start and end
quotes.

If I modify my diff viewer settings to the following:

  C:\Temp\test.bat %brev %yrev %burl" %yurl"

Then I get the intended result:

rev one is "1796"
rev two is "1797"
url one is "http://example.com/trunk/.project"
url two is "http://example.com/trunk/.project"

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3047714

To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2013-02-05 17:56:49 CET