Re: Bad quoting of URL keywords passed to external diff viewer

On 05.02.2013 17:56, Ben Fritz wrote:
> I had trouble trying to configure diff pane names in KDiff3 to include
> both URL and revision, like %burl@%brev.
>
> For testing, I used the following .bat file contents as a diff viewer:
>
> @echo off
> setlocal
>
> echo rev one is %1
> echo rev two is %2
> echo url one is %3
> echo url two is %4
> pause
>
> :END
> endlocal
> echo on
>
> I set up my diff viewer settings to invoke it as follows:
>
> C:\Temp\test.bat %brev %yrev %burl %yurl
>
> This results in:
>
> rev one is "1796"
> rev two is "1797"
> url one is "http://example.com/trunk/.project "http://example.com/trunk/.project
> url two is "C:\tmp\.project-rev1796.svn007.tmp.project"
>
> Notice that %burl is missing an end quote. I'm not 100% sure it needs
> to be quoted at all, but certainly it should have both start and end
> quotes.
>
> If I modify my diff viewer settings to the following:
>
> C:\Temp\test.bat %brev %yrev %burl" %yurl"
>
> Then I get the intended result:
>
> rev one is "1796"
> rev two is "1797"
> url one is "http://example.com/trunk/.project"
> url two is "http://example.com/trunk/.project"

Maybe this is relevant here:
http://code.google.com/p/tortoisesvn/issues/detail?id=449

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3047738
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].