On 17 September 2012 15:51, Paul Claessen <paul_at_claessen.com> wrote:
> I was afraid that would be the response.
> Allow me to elaborate:
>
> I know that at the lowest level, every modification results in deleting a line, and replacing it with a modified line.
> But the 'strike-through' feature, I think, should be implemented at the 'user level', that is: lines completely removed (no longer there) in the latest revision, should be 'stricken through' in the older version, so as to clearly visualize what has been removed.
>
> It doesn't seem to make sense to use 'strike-out' on EVERY modified line: first of all, modified lines are ALREADY marked, and second, strike-out makes them hard to read (and for modified lines, you probably want to see what the modifications are).
> In other words, the current implementation doesn't add anything to marking changes (other than making them harder to read), as where the idea of clearly marking DELETED lines (from the USER'S perspective, NOT from how the modify engine works behind the scenes!) simply isn't implemented.
>
> If a USER is offered an option for a strike-out on all DELETED lines, he doesn't expect strike-out to be applied to all MODIFIED lines (which are already marked anyway).
I agree on this one. The line is already marked as deleted using the
minus sign in the line number bar. In fact I wonder if strikethrough
is actually useful at all, even for lines which have been deleted
completely. As Paul says, they are already marked and this just makes
them harder to read.
> In short, I think this should be a user level feature, not based on how things work at the lowest level.
> (Other diff/compare programs, like BeyondCompare) do this correctly)
I don't think there is a universal definition of what is correct in
this instance. They just do it the way you prefer ;-)
Simon
--
: ___
: oo // \\ "De Chelonian Mobile"
: (_,\/ \_/ \ TortoiseSVN
: \ \_/_\_/> The coolest Interface to (Sub)Version Control
: /_/ \_\ http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3006502
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2012-09-17 17:25:23 CEST