[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [tortoisesvn] r24370 committed - Improve space/tab inconsistency detection:...

From: Oto BREZINA <brezina_at_printflow.eu>
Date: Thu, 13 Jun 2013 21:11:31 +0200

On 2013-06-13 19:21, tortoisesvn_at_googlecode.com wrote:
> Revision: 24370
> Author: tortoisesvn
> Date: Thu Jun 13 10:21:40 2013
> Log: Improve space/tab inconsistency detection:
> * only if there are consecutive spaces to match a tab is the file marked as
> using spaces
> * only if there are tabs is the file marked as using tabs
> * only if both tabs and spaces are used is the file marked as space/tab
> inconsistent.

While reading this keep in mind I don't want nor meant to attack in any way.
However I don't know what this revision improved over let say r24355.
I thought "fix before save" will be simple improvement over manual
invocation, but seems its getting over us.

It detect tabs even after first non space/tab character - that will not
be converted (intentionaly) so offer is not adequate. Same for spaces.
  1. our line formating as follow"<tab><tab>Call()<few spaces>// make a
call" will offer tab->spaces
  2. space indented line "<8 spaces>Indent "<tab>" // will offer spaces->tab
one line with two tabs and other with 8 spaces offers BOTH on save!

If there is one space between two tabs, If will not help me to clean it
up anymore
If both tabs and spaces are used I get convert tabs to spaces (I preffer
tabs) no way to configure anymore.

I agree tri-state config was a little bit confusing but coverted 98% of
cases if you understand it, now I get under 50%.



To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2013-06-13 21:11:37 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.