[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: UI Proposal for Code Collaborator settings

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Fri, 14 Jun 2013 17:03:04 +0200

On 13.06.2013 23:30, Friedrich Brunzema wrote:
> Couple of ideas regarding this functionality:
> 1. The detection logic for CC is broken on x64 systems, as CC has both an x86 and x64 client. Result is that the program is always installed in %program files%\..\ and never in Program Files (x86). I will fix this.
> 2. There is a usability issue for single commits. Currently, the user has to
> 1. Commit his/her code
> 2. Do a SVN->Log
> 3. Right Click the new revision just checked in
> 4. Choose Create Code Collaborator review.
> I propose adding a way to automatically create a code review if:
> 1. Collaborator is installed
> 2. Collaborator is configured in the registry
> 3. User presses Ctrl while clicking OK
> This would do the normal commit, and upon success get the commit rev# and do the normal create review functionality.

> An alternative to (3) is to have a checkbox between the Keep Locks checkbox and the Show Log button. This would probably entail increasing the min width of the dialog by 1-2cm to make room for a "Create Review" checkbox. The wider dialog limits would only apply if the program is installed and the checkbox would also only show if installed.
> The good: More visibility, less hacky then control+OK
> The bad: A bit more complexity in the commit dlg.
> Right now my gut feeling is not to do the UI option but to use the Ctrl+OK

That's actually what either a pre-commit hook script is for or an issue
tracker plugin. No need to mess with the TSVN code for this.

You could write a client-side hook script:

in this situation, I would recommend using the post-commit hook, since
you don't want to mess with CC if the commit fails but only if the
commit succeeded. That script is called after the commit is finished so
you can mess with CC at a time when all the info about the commit is
already available.

If you need something more complicated, you can implement an issue
tracker plugin:

The method CheckCommit() is called right before the commit dialog is
closed and the commit is about to start. You have there the ability to
stop the commit dialog from closing and show the user e.g. an error
message if something is missing or wrong.

The method OnCommitFinished() is called after the commit has finished
and you could then add a review task for that revision to CC.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2013-06-14 17:03:17 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.