[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: UI Proposal for Code Collaborator settings

From: Friedrich Brunzema <brunzefb_at_yahoo.com>
Date: Thu, 13 Jun 2013 14:30:25 -0700 (PDT)

Couple of ideas regarding this functionality:
1. The detection logic for CC is broken on x64 systems, as CC has both an x86 and x64 client. Result is that the program is always installed in %program files%\..\ and never in Program Files (x86). I will fix this.

2. There is a usability issue for single commits. Currently, the user has to
1. Commit his/her code
2. Do a SVN->Log
3. Right Click the new revision just checked in
4. Choose Create Code Collaborator review.

I propose adding a way to automatically create a code review if:
1. Collaborator is installed
2. Collaborator is configured in the registry
3. User presses Ctrl while clicking OK
This would do the normal commit, and upon success get the commit rev# and do the normal create review functionality.

An alternative to (3) is to have a checkbox between the Keep Locks checkbox and the Show Log button. This would probably entail increasing the min width of the dialog by 1-2cm to make room for a "Create Review" checkbox. The wider dialog limits would only apply if the program is installed and the checkbox would also only show if installed.
The good: More visibility, less hacky then control+OK
The bad: A bit more complexity in the commit dlg.

Right now my gut feeling is not to do the UI option but to use the Ctrl+OK



To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2013-06-13 23:30:27 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.