[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: bug with 'undo add' command

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Fri, 24 Aug 2012 19:55:58 +0200

On 24.08.2012 17:05, Xu Hong wrote:
> I created a patch for this issue , I think it would be better do not
> select unversioned files
> default when a user click on a 'Undo Add' menu . and it's also would
> no impact on
> performance . Thanks .

Thanks for the patch. But it's actually useless:
* unversioned files are not even shown in the revert dialog
* the context menu isn't shown for unversioned files either

The problem is that if you select multiple items in explorer (not in a
TSVN dialog) and then right-click on a modified item, then you can
revert also unversioned files: because then, TSVN gets a list of all
selected files which might not even be in the same folder (i.e., if you
use the search window).
As I said before: to avoid reverting unversioned files in this situation
would require to fetch the status first of each and every single file
separately. Imagine doing that if a user hit Ctrl-A in a folder with
1000 files...

> I am a Chinese user, but my TortoiseSVN Language is 'English', I don't
> konw why the
> patch file contains Chinese words. I am not sure about that if the
> patch can be used on an
> English operation system.

It can: the Chinese words are only on context data.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3000788
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2012-08-24 19:56:09 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.