[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: bug with 'undo add' command

From: Xu Hong <icehong_at_gmail.com>
Date: Fri, 24 Aug 2012 23:05:22 +0800

I created a patch for this issue , I think it would be better do not
select unversioned files
default when a user click on a 'Undo Add' menu . and it's also would
no impact on
performance . Thanks .

I am a Chinese user, but my TortoiseSVN Language is 'English', I don't
konw why the
patch file contains Chinese words. I am not sure about that if the
patch can be used on an
English operation system.

2012/8/17 徐鸿 <icehong_at_gmail.com>:
> Anyway I think svn should not delete unversioned files without an
> explicit 'delete' command.
> I thought the files was losted when I meet this probelm the first time.
>
> BTW, tsvn&&svn is the best source management tools I have used.
> Thanks for all of yours develops .
>
> 2012/8/17 Stefan Küng <tortoisesvn_at_gmail.com>:
>> On 16.08.2012 17:01, Xu Hong wrote:
>>> How to produce it:
>>> make two file named a.txt and b.txt in a versioned dir
>>> svn add a.txt to be versioned but do not to commit
>>> select a.txt and b.txt together, right click on file a.txt ,
>>> can see the context menu "undo Add..", click on "undo Add.."
>>>
>>> the two files was selected default in the Revert window,
>>> click "OK", a.txt was revert to unversion status but b.txt was
>>> deleted !!!
>>
>> That's a known issue: we only check the status of the first file, so if
>> you select unversioned files as well TSVN doesn't know that.
>> The unversioned file is only deleted if you have the option "use recycle
>> bin when reverting" is active (settings->general->dialogs 1).
>> And as the option says: the file is moved to the Windows recycle bin, so
>> you can get it back from there.
>>
>> Checking whether the file is unversioned before doing the reverting
>> could be done of course, but it would mean a huge performance impact and
>> that's why we don't do that. We rely on the fact that you either
>> right-click on a folder to get the revert dialog, or only select the
>> files you really want to revert.
>>
>> Stefan
>>
>> --
>> ___
>> oo // \\ "De Chelonian Mobile"
>> (_,\/ \_/ \ TortoiseSVN
>> \ \_/_\_/> The coolest Interface to (Sub)Version Control
>> /_/ \_\ http://tortoisesvn.net
>>
>> ------------------------------------------------------
>> http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2998965
>>
>> To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3000753

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2012-08-24 17:07:02 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.