[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Cursor

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Tue, 17 May 2011 18:42:34 +0200

On 16.05.2011 22:57, Oto BREZINA wrote:
> Current cursors is moving over screen lines. So you can start type
> anywhere like after end of wrapped line.
> As I wrote I thought about convert cursor into view line coordinates,
> but this would forbiden this. I think this is not intended bahaviour anyway.
> However stoping on start of view line is needed to navigate over file.
> Navigation thru screen (wrapped) line may be needed too (without editing?).
>
> Note cursor using View coordinates is needed to work with wrap lines.
> otherwise lot jumping, unexpected moving and other things happen.
> I thought also about using both coordines in paralel but I was not able
> to solve it make it to work for all cases.
>
> In current implementation. you can start writing at ANY line.
> I'm not sure if this is good practice however. Empty line you can
> convert by this way into regular line may be line after original file
> thus new line is missing in previous line.
> Also line gets EOL if don't have any yet. I would preffer to don't add
> EOL - there is no reason to have it on last line in some cases (formats).
> So final solution is:
> * Don't add EOL except it is not last line and is converted from EMPTY.
> * make sure previous non empty line have EOL (if actual one was EMPTY)

That looks good.

> Note that you can edit even deleted line(DIFFSTATE_REMOVED), conflicted
> and even colapsed too.

I would left those editable: they get changed to DIFFSTATE_EDITED and
will be saved too.

> If there is nobody against this I would change that.

Sure, go ahead :)

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2739370
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-05-17 18:42:40 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.