[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch - unused variable, suboptimal code placement

From: Dmitry <wipedout_at_yandex.ru>
Date: Tue, 19 Apr 2011 09:48:03 +0400


18.04.11, 23:35, "Oto BREZINA" <otik_at_printflow.eu>:
> I still wonder how you are looking for thiese bugs. Are you reading code
> from to bottom? I found that Views can be improved when Stefan fix some
> issue and he made same change on four places.
> > Committed in r21178.
> What about this :)
Sometimes I actually read from top to bottom, but most of the time I open some file at random location and start looking through it until I find something that drags my attention - that's usually something minor. For example, in this patch I noticed that <degue> header was included which I know is quite uncommon in the project, so I searched for all usages of class deque and found an unused variable.

Best wishes.


To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-04-19 07:48:12 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.