[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch - unused variable, suboptimal code placement

From: Oto BREZINA <otik_at_printflow.eu>
Date: Mon, 18 Apr 2011 21:35:58 +0200

On 2011-04-18 18:32, Stefan Küng wrote:
> On 18.04.2011 08:02, Dmitry wrote:
>> Hey.
>>
>> Attached is an untested path that addresses an unused variable, suboptimal code placement, too wide scope.
I still wonder how you are looking for thiese bugs. Are you reading code
from to bottom? I found that Views can be improved when Stefan fix some
issue and he made same change on four places.
> Committed in r21178.
What about this :)
* Suboptimal code placement fix improvement

While looking at code around I found that m_sWindowName is changed too
often. Second patch address this.
* Don't change WindowName attribute to reflect changed state anymore,
instead change draw text only
> Stefan

-- 
Oto BREZINA, Printflow s.r.o., EU
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2721135
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].


Received on 2011-04-18 21:36:10 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.