Re: [T-Merge patch] syncing code for views

On 07.04.2011 21:03, Oto BREZINA wrote:
> On 2011-04-07 19:16, Stefan Küng wrote:
>> On 07.04.2011 00:11, Oto BREZINA wrote:
>>> sometime if (m_pwndBottom->IsViewLineConflicted(viewLine)) is used while on other places not.
>> It's used whenever the bottom view is visible. Or do you see another place?
>
> It is not in: CBottomView::UseMyTextBlock
> While it is in: CBottomView::UseTheirTextBlock, CLeftView::UseBlocka and
> CRightView::UseBlock(

Ups, you're right. That's a bug.
Fixed in r21121.

> btw: m_nSelBlockStart and m_nSelBlockEnd synced for all views, or can be
> different?

It should not be different.

> I think about add 'static allviewstate m_allviewstate' into BaseView.
> Then usage would be as follow:
> ClearUndoStep();
> ... call methods copiing data, modififyng state ...
> AddUndoStep(caret); // will not add if no data to add
> This removes creating, and pushing states ...
> btw

Looks like a good idea.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2717788
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].