[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Patch: Bracket class for CloseClipboard()

From: Dmitry <wipedout_at_yandex.ru>
Date: Wed, 20 Jan 2010 18:32:24 +0300

Hey.

In TSVN StringUtils.cpp CloseClipboard() is called way too often. Patch to combat that follows.

Also I find how SetClipboardData() is used confusing.

In CStringUtils::WriteAsciiStringToClipboard() if the first call return non-null ("success") control falls through. Do I get it right that "false" will be returned in this case? Is this what is intended?

Later around the second call to SetClipboardData() GlobalAlloc() is called - even if it returns null ("failure") control falls through and "true" is returned. Is this what is intended?

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2440659

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2010-01-20 17:12:44 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.