Re: Patch: Wrong ownership sematics for BSTRs

On 20.01.2010 07:50, Dmitry wrote:
> I wonder what was the exact reason for r18375? We've been using CComPtr<MostDerivedClass> for ages in our codebase.

this one:

1>c:\program files (x86)\microsoft visual studio
9.0\vc\atlmfc\include\atlcomcli.h(106) : warning C4510:
'ATL::_NoAddRefReleaseOnCComPtr<T>' : default constructor could not be
generated
1> with
1> [
1> T=CShellExtClassFactory
1> ]
1>
d:\development\svn\tortoisesvn\src\tortoiseshell\tortoisesvn.cpp(169) :
see reference to class template instantiation
'ATL::_NoAddRefReleaseOnCComPtr<T>' being compiled
1> with
1> [
1> T=CShellExtClassFactory
1> ]
1>c:\program files (x86)\microsoft visual studio
9.0\vc\atlmfc\include\atlcomcli.h(106) : warning C4610: class
'ATL::_NoAddRefReleaseOnCComPtr<T>' can never be instantiated - user
defined constructor required
1> with
1> [
1> T=CShellExtClassFactory
1> ]

I don't like the "default constructor could not be generated" at all.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2440690
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].