Re: Patch: Bracket class for CloseClipboard()

On 20.01.2010 16:32, Dmitry wrote:
> Hey.
>
> In TSVN StringUtils.cpp CloseClipboard() is called way too often.
> Patch to combat that follows.
>
> Also I find how SetClipboardData() is used confusing.
>
> In CStringUtils::WriteAsciiStringToClipboard() if the first call
> return non-null ("success") control falls through. Do I get it right
> that "false" will be returned in this case? Is this what is
> intended?
>
> Later around the second call to SetClipboardData() GlobalAlloc() is
> called - even if it returns null ("failure") control falls through
> and "true" is returned. Is this what is intended?

Ups, you found a bug there.
I've redone your patch according to your comments in r18386.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2440712
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].