Re: Patch: Wrong ownership sematics for BSTRs

Okay, then here's the next patch. Introduces CComPtr where applicable, reduces duplication, cleans up here and there, eleminates an object leak ("pcdl" variable in CTortoiseProcApp::InitializeJumpList()).

I noticed that in RemoteCacheLink prior to calling CreateProcess() CString::GetBuffer() is called to access the underlying string. Why is this? Wouldn't casting to LPCTSTR be enough? In that case subsequent calls to CString::ReleaseBuffer() on both if-branches would be unnecessary.

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2440170

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].