Re: Patch: Wrong ownership sematics for BSTRs

On 19.01.2010 08:32, Dmitry wrote:
> Okay, then here's the next patch. Introduces CComPtr where
> applicable, reduces duplication, cleans up here and there, eleminates
> an object leak ("pcdl" variable in
> CTortoiseProcApp::InitializeJumpList()).

Thanks!
Committed in r18374 with some tweaks.

> I noticed that in RemoteCacheLink prior to calling CreateProcess()
> CString::GetBuffer() is called to access the underlying string. Why
> is this? Wouldn't casting to LPCTSTR be enough? In that case
> subsequent calls to CString::ReleaseBuffer() on both if-branches
> would be unnecessary.

You're right. I guess that was a leftover from where CreateProcess was
called directly there.

Fixed in r18376.

For your next patches, please do not reply to this thread - the subject
line doesn't match anymore.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2440360
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].