Re: Patch: reducing code duplication by using functions

On 31.08.2009 11:49, Oto BREZINA wrote:
> I have few question/notes about this patch.
>
> 1.*ptr != buffer*// according some rule we (in our company - not TSVN) use comparing pointers is classified as not safe

It's safe if done right. It's just easy to mess it up.

> 2. using ptr[i] is faster anyway - according intel optimazition manual (at least as i remmember)

I though pointer arithmetic was faster - but I guess with todays
optimizing compilers it won't make a difference.

> 3. where two ending \NUL becomes from ? Should be this function responsible for this, or at least test it ?

The function converts '|' chars into \0 chars. The string itself
contains two || at the end. The function doesn't have to check or even
do it (it can't really do it - appending isn't allowed because that
would cause a buffer overflow).

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2389500
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].