[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch: reducing code duplication by using functions

From: Oto BREZINA <otik_at_e-posta.sk>
Date: Mon, 31 Aug 2009 11:49:08 +0200

I have few question/notes about this patch.

1.*ptr != buffer*// according some rule we (in our company - not TSVN) use comparing pointers is classified as not safe
2. using ptr[i] is faster anyway - according intel optimazition manual (at least as i remmember)
3. where two ending \NUL becomes from ? Should be this function responsible for this, or at least test it ?

Anyway thanks for you patches it good inspiration...

Oto

On 2009-08-31 07:24, Dmitry wrote:
> Hey.
>
> Here's another patch reducing code duplication, specifically the routine for replacing '|' with a NULL character used every here and there. Review needed - not tested.
>
> Best wishes.
> Dmitry.
>
> ------------------------------------------------------
> http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2388743
>
> To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
>
>
> ________ Information from NOD32 ________
> This message was checked by NOD32 Antivirus System for Linux Mail Servers.
> part000.txt - is OK
> Patch-PipesToNullsAndMinorChanges.patch - is OK
> http://www.eset.com

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2388813

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-08-31 11:50:25 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.