[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch: auto_ptr is frequently abused in TSVN code

From: Dmitry <wipedout_at_yandex.ru>
Date: Mon, 31 Aug 2009 13:52:00 +0400

Hey.

Here's another patch using auto_buffer for array lifetime management. It also addresses unused local CString variables found every here and there, redundant nested code blocks and rewrites long methods for less block nesting and reduces code duplication.

The patch is untested and needs a review.

Also in SetColorPage.cpp there is (and was) a local variable "adjustedcolor" that is not initialized and passed as an in parameter to a function. That's undefined behaviour. I have no idea of what correct code should be at that place.

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2388814

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2009-08-31 11:55:30 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.