[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Bug(?) in TortoiseProc\LogDlg.cpp

From: Zink, Dan <Dan.Zink_at_hp.com>
Date: Tue, 18 Aug 2009 19:56:37 +0000

I was looking at http://tortoisesvn.tigris.org/svn/tortoisesvn/trunk/src/TortoiseProc/LogDlg.cpp as an example of parsing log data and found something that looks wrong.

Line 946:

        else if (m_startrev.IsNumber() && m_startrev.IsNumber())
                m_LogProgress.SetPos((svn_revnum_t)m_startrev-rev+(svn_revnum_t)m_endrev);

Should that second m_startrev be m_endrev?

        else if (m_startrev.IsNumber() && m_endrev.IsNumber())
                m_LogProgress.SetPos((svn_revnum_t)m_startrev-rev+(svn_revnum_t)m_endrev);

Regards,
Dan Zink

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2384946

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-08-18 22:03:25 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.