[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug(?) in TortoiseProc\LogDlg.cpp

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Wed, 19 Aug 2009 17:16:30 +0200

On 18.08.2009 21:56, Zink, Dan wrote:
> I was looking at http://tortoisesvn.tigris.org/svn/tortoisesvn/trunk/src/TortoiseProc/LogDlg.cpp as an example of parsing log data and found something that looks wrong.
>
> Line 946:
>
> else if (m_startrev.IsNumber()&& m_startrev.IsNumber())
> m_LogProgress.SetPos((svn_revnum_t)m_startrev-rev+(svn_revnum_t)m_endrev);
>
> Should that second m_startrev be m_endrev?
>
> else if (m_startrev.IsNumber()&& m_endrev.IsNumber())
> m_LogProgress.SetPos((svn_revnum_t)m_startrev-rev+(svn_revnum_t)m_endrev);

You're absolutely right.
Fixed in r16963.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2385269
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-08-19 17:17:00 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.