Re: SV: Idea: tsvn:revlogregex

Hans-Emil Skogh wrote:
>>> I'm, as I'm sure many of you are, quite often referring to other
>>> revisions in my commit messages.
>>> How about adding a new property to be able to define a regular
>>> expression to enable TSVN to recognize these references and create links
>>> from them.
>> You'd might be surprised, but I'm currently working on this (still in
>> the early stages though).
>
> :-)
>
>> But I don't think we need another regex property for this: I thought
>> of simply parsing for 'rXXX' should be enough.
>
> For us that wouldn't be enough... We have a mix of references like:
> "rev. 1234" and "revision 1234" (including alternate casing), but I
> don't think any "r1234"...

I think since I'm planning to use regex to parse the message, it
shouldn't be too difficult to include 'rev. XXX', 'rev XXX' and
'revision XXX' too.
Of course, only if the match for those revisions doesn't match a bugtraq
issue, those will have priority.

>> Of course, a revision would only be turned into a link if the revision
>> is already shown in the log dialog - otherwise revisions which relate to
>> other projects would confuse the whole logic (e.g., a TSVN commit
>> references a revision of the svn project or another external).
> Hmm... I guess you are right. We are not making heavy use of externals,
> so confusing with other projects would probably not be a problem at this
> point in time, but who knows about the future. A possible future
> improvement (to the future improvement :-) ) could be yet another
> property that could toggle the link creation for revisions not in the
> current log dialog.
> The reason that I'm keen on having working links to revisions not shown
> in the current log dialog view is that we are using branches, and
> sometimes links to revisions present on other branches (but in the same
> repository) makes very much sense.

Since the log cache already has *all* revisions (well, usually it does),
we could use that to find out whether a revision is 'available' without
contacting the repository.

Stefan^2, could you implement some log cache helper functions please?

I'm thinking of:

bool IsRevisionAvailable(svn_revnum_t revision);
LogEntryData * GetRevisionData(svn_revnum_t revision);

this would maybe even allow to just show a tooltip on such revision
texts with the info from that revision.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=1772021
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].