Re: Bug in pathList parameter passed to IBugTraqProvider2 CheckCommit and OnCommitFinished

webpost_at_tigris.org wrote:
> Responding to my own post, I think I see part of the problem.
>
> In CommitDlg::OnOk(), slightly before the call to CheckCommit, there is an if statement around this line:
> m_ListCtrl.WriteCheckedNamesToPathList(m_pathList);
>
> This if statement prevents this line from being called when all items are selected. However, I think the real issue is that CheckCommit is being called with data from m_pathList, while there is a variable called m_selectedPathList that I think should be used for CheckCommit() instead. This variable is set outside of the if statement, so it should provide all the data we need.

Correct.

> The call to OnCommitFinished is being made from SVNProgressDlg, with data set in SetPath(), but I haven't yet determined where that call is coming from.

The OnCommitFinished is called with the paths that actually got
committed (the paths shown in the progress dialog).

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=1729160
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].