RE: Bug in pathList parameter passed to IBugTraqProvider2 CheckCommit and OnCommitFinished

Responding to my own post, I think I see part of the problem.

In CommitDlg::OnOk(), slightly before the call to CheckCommit, there is an if statement around this line:
                m_ListCtrl.WriteCheckedNamesToPathList(m_pathList);

This if statement prevents this line from being called when all items are selected. However, I think the real issue is that CheckCommit is being called with data from m_pathList, while there is a variable called m_selectedPathList that I think should be used for CheckCommit() instead. This variable is set outside of the if statement, so it should provide all the data we need.

The call to OnCommitFinished is being made from SVNProgressDlg, with data set in SetPath(), but I haven't yet determined where that call is coming from.

Hope this helps!

Jim Z.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=1728568

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-04-15 17:30:11 CEST