[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: I would like to extend the interface of SubWCRevCOM. Would that be okay for you?

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Sun, 10 Feb 2008 17:05:55 +0100

Michael Hegmann wrote:
> Hello Stefan,
>
> Please receive my patch for SubWCRevCom attached to this email.
> I did the following changes:
> 1. Extend the inteface with VARIANTS as described below (VARIANTS
> instead of BSTR)
> 2. Modified testCom.js to test the new functionality, too
> 3. Modified the setup of SubWCRevCom slightly
>
> Could you please check these changes and help me with the
> modifications of SubWCRev.exe (see question 3 below)?

Thanks for the patch. I've had to make some changes though.
Committed in revision 12091.

The changes I made:
* you forgot to extend SubWCRev itself to have the replacement strings
* in UnescapeCopy(), you've incremented the 'len' variable inside the
loop, even though the loop itself increments it already. Did that ever
work for you correctly?
* in the setup file, you wanted to set the path to [INSTALLDIR]bin
instead of just [INSTALLDIR]. But that's wrong because that setup file
is used for the static install, not the TSVN one. And the static
installation does not have a bin directory.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net

Received on 2008-02-10 17:06:13 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.