Re: I would like to extend the interface of SubWCRevCOM. Would that be okay for you?

Hello Stefan,

Please receive my patch for SubWCRevCom attached to this email.
I did the following changes:
   1. Extend the inteface with VARIANTS as described below (VARIANTS
instead of BSTR)
   2. Modified testCom.js to test the new functionality, too
   3. Modified the setup of SubWCRevCom slightly

Could you please check these changes and help me with the
modifications of SubWCRev.exe (see question 3 below)?

Best Regards
Michael

2008/2/3, Stefan Küng <tortoisesvn_at_gmail.com>:
> Michael Hegmann wrote:
>
> > ... to get the TSVN status and the locking
> > status of the active document.
> > Depending on the status the user can choose whether to commit the
> > document keeping the lock or to commit it releasing the lock.
> >
> > For getting the status of the document I extended the interface of
> > SubWCRevCOM by the following functions:
> >
> > [propget, helpstring("TRUE if the file or folder is under SVN
> > version control")]
> > HRESULT IsSvnItem([out, retval]VARIANT_BOOL* svn_item);
> >
> > [propget, helpstring("TRUE if locking is generally required for the
> > requested file / folder")]
> > HRESULT NeedsLocking([out, retval]VARIANT_BOOL* needs_locking);
> >
> > [propget, helpstring("TRUE if the file or folder is locked")]
> > HRESULT IsLocked([out, retval]VARIANT_BOOL* locked);
> >
> > [propget, helpstring("Returns the owner of the lock")]
> > HRESULT LockOwner([out, retval]BSTR* owner);
> >
> >
> >

> > Question 3:
> > If you are okay with the extended interface, should I extend the
> > interface of SubWCRev, too?
>
> Yes please. They're both "SubWCRev", just one exposes the COM interface.
> So I'd like to keep the features consistent for both.
>
> Stefan
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: dev-help_at_tortoisesvn.tigris.org