Re: I would like to extend the interface of SubWCRevCOM. Would that be okay for you?

Hello Stefan,

> Thanks for the patch. I've had to make some changes though.
> Committed in revision 12091.

Thank you for reviewing the code, doing the changes and applying the patch!

> * in UnescapeCopy(), you've incremented the 'len' variable inside the
> loop, even though the loop itself increments it already.

Regarding the 'len' variable I was a little bit confused and thought
it is for the source length. :-( Now I have seen that it is for the
destination buffer length.

> * in the setup file, you wanted to set the path to [INSTALLDIR]bin
> instead of just [INSTALLDIR]. But that's wrong because that setup file
> is used for the static install, not the TSVN one. And the static
> installation does not have a bin directory.

Could you please tell me more about the idea of the static setup? Is
SubWCRevCOM available as a part of a static setup and within the TSVN
setup?

> * you forgot to extend SubWCRev itself to have the replacement strings

Thank you very much for doing so!

Best Regards,
Michael

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: dev-help_at_tortoisesvn.tigris.org
Received on 2008-02-10 22:43:24 CET