Stefan Küng wrote:
> Roger Lipscombe wrote:
>> Also, I'm wondering how best to tackle the following two issues:
>> 1. The issue tracker hook should almost always have "Wait for the
>> script to finish" checked. Otherwise how are we going to get the
>> message back? This'll require a little more code in the configuration
>> dialog.
> The problem I have here is that while TSVN has to wait for the script
> to finish, it is basically blocked.
>
> How about implementing a custom window message which the script could
> send, containing the modified text?
>
> That way, TSVN could simply start the script and go on. The script
> once it has the information it needs could then send the message back
> to the TSVN commit dialog.
The problem with allowing TSVN to carry on is that the user could then
enter something else in the box, which we'd end up overwriting later:
classic race condition. I'd also prefer not to do things with registered
window messages, or even WM_SETTEXT, because that limits the
implementation options for the hook. At the moment, it even works with a
simple batch file.
Obviously, because the hook's blocking the UI thread, there'll be redraw
problems.
I think that, in order to preserve the expected UI behaviour (i.e. so
that it looks like any dialog brought up by the hook is modally nested
inside TSVN), we'll need to disable the dialog and wait for the hook in
a separate thread. Granted, it's not going to be asynchronous, but I
think it's the simplest way to do this. I'll think about this some more.
>> 2. How best to allow configuration of the text on the button that's
>> added to the Commit dialog.
>
> Is that necessary?
>
Well, it currently says "Bug Tracker...". Some people (a previous boss
springs to mind) don't like the word "bug". They prefer the word
"issue". I guess it can stay as it is for now.
Roger.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: dev-help_at_tortoisesvn.tigris.org
Received on 2008-02-02 17:54:02 CET