[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issue Tracker Integration

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Sat, 02 Feb 2008 17:35:19 +0100

Roger Lipscombe wrote:

> Excellent. I'll try to find some time on Monday to add some doxygen
> comments to it, and to update the documentation, if possible. I'm also
> thinking that I might change it so that the bugtraq: properties have a
> higher priority (since they're properties of the repos, rather than of
> the TSVN installation, I figure that they're more specific, and should
> be honoured in preference). Any thoughts about this?

I would just leave it as it is right now.
But maybe wait for others to express their opinion - I'm maybe not the
one you should listen to here...

> Also, I'm wondering how best to tackle the following two issues:
> 1. The issue tracker hook should almost always have "Wait for the script
> to finish" checked. Otherwise how are we going to get the message back?
> This'll require a little more code in the configuration dialog.

The problem I have here is that while TSVN has to wait for the script to
finish, it is basically blocked.

How about implementing a custom window message which the script could
send, containing the modified text?

That way, TSVN could simply start the script and go on. The script once
it has the information it needs could then send the message back to the
TSVN commit dialog.

Or: instead of registering a custom window message, pass the handle of
the edit control in the commit dialog (converted to a LONG) to the
script, and the script could then use the existing message WM_SETTEXT to
change the text of the control directly.
(WM_SETTEXT is handled differently by Windows than other messages, to
make it easier to send it cross-process and also it caches the text to
send).

> 2. How best to allow configuration of the text on the button that's
> added to the Commit dialog.

Is that necessary?

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net

Received on 2008-02-02 17:35:39 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.