[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

I would like to extend the interface of SubWCRevCOM. Would that be okay for you?

From: Michael Hegmann <michael.hegmann_at_googlemail.com>
Date: Sat, 2 Feb 2008 22:59:02 +0100

Hello everybody!

I think that TortoiseSVN is really great and therefore I would like to
convince my colleagues to use it for our daily work.

As we are mainly writing MS Office papers I have coded a pretty small
Add-In for Word and Excel to get the TSVN status and the locking
status of the active document.
Depending on the status the user can choose whether to commit the
document keeping the lock or to commit it releasing the lock.

For getting the status of the document I extended the interface of
SubWCRevCOM by the following functions:

                [propget, helpstring("TRUE if the file or folder is under SVN
version control")]
                HRESULT IsSvnItem([out, retval]VARIANT_BOOL* svn_item);

                [propget, helpstring("TRUE if locking is generally required for the
requested file / folder")]
                HRESULT NeedsLocking([out, retval]VARIANT_BOOL* needs_locking);
                
                [propget, helpstring("TRUE if the file or folder is locked")]
                HRESULT IsLocked([out, retval]VARIANT_BOOL* locked);
                
                [propget, helpstring("Returns the owner of the lock")]
                HRESULT LockOwner([out, retval]BSTR* owner);

Question 1:
Could you please tell me whether these interface extensions are okay
for you and whether I can commit them?

Question 2:
In the existing interface of SubWCRevCOM VARIANTs are used instead of
BSTRs. Could anybody please tell me the reasons for doing so? Should I
use VARIANTs instead of BSTRs, too?

Question 3:
If you are okay with the extended interface, should I extend the
interface of SubWCRev, too?

Best Regards
Michael

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: dev-help_at_tortoisesvn.tigris.org
Received on 2008-02-02 22:59:13 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.