Alexander Klenin wrote:
> On 10/10/07, Stefan Küng <tortoisesvn@gmail.com> wrote:
>> Kloster Oddvar wrote:
>>> LogDlg:
>>> * Pressing Enter or doubleclicking on a log line opens the list of file
>>> diffs from previous rev. If just one file was modified in the rev, diffs
>>> the file directly instead.
>>> * Pressing Enter on a file in lower list opens diff from prev rev.
>> I have some comments though:
>> * we disabled the diff for doubleclicks a long time ago because
>> accidental doubleclicks (yes, they happen more often than you might
>> think) would lead to sometimes lengthy operations which the user didn't
>> wanted. So if you really want to do this, you'd have to add an option to
>> disable that feature - best in the "Dialogs 1" page under "Log
>> messages". Just move the "Progress", "Merge" and "Checkout" groups a
>> little bit down and you'll have enough space for another checkbox.
>
> I am slightly confused here. IIUC, the list of files different from
> previous revision
> is already displayed in the bottom list pane of the log dialog, so:
> 1) Do we really need this menu item at all?
> 2) If yes, then I do not see a reason for it to be slow (and thus to
> be configurable) --
> just take already fetched list.
Good point. Yes, the list of changed files already is shown in the
bottom pane. But do show the diff between the previous and the
doubleclicked revision, we use a completely different API to actually
get the diff.
The menu entry (not the doubleclick) is actually shown for single
revisions as for two selected revisions (where it makes much more sense).
The entry for a single revision is actually only shown for users
convenience.
> Finally, code form CLogDlg::DiffSelectedRevWithPrevious function in the patch
> seems vaguely familiar -- was it copy-pasted from other function?
> If so, perhaps a better way is to extract common code?
The log dialog has a lot of refactoring potential :)
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed Oct 10 17:54:01 2007