[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Keyboard shortcuts in log

From: Stefan KŁng <tortoisesvn_at_gmail.com>
Date: 2007-10-10 17:48:54 CEST

Kloster Oddvar wrote:
>> From: Stefan KŁng [mailto:tortoisesvn@gmail.com] Thanks for the
>> patch! I have some comments though: * we disabled the diff for
>> doubleclicks a long time ago because accidental doubleclicks (yes,
>> they happen more often than you might think) would lead to
>> sometimes lengthy operations which the user didn't wanted. So if
>> you really want to do this, you'd have to add an option to disable
>> that feature - best in the "Dialogs 1" page under "Log messages".
>> Just move the "Progress", "Merge" and "Checkout" groups a little
>> bit down and you'll have enough space for another checkbox.
>
> It's true that the operation can take a long time, but in that case a
> progress window appears and allows the user to cancel. I guess this
> might not have been in place when you disabled the doubleclick? Is
> avoiding accidental diffs still important enough to warrant the
> option?

Yes, because it can be really annoying if you often get accidental
doubleclicks (depends on the user).

>> * you removed the tab stops from the edit boxes in the file diff
>> dialog. Why? Users still want to tab into those to copy the text
>> from there.
>
> I tested that before disabling them, but was not able to copy the
> text in those boxes... Anyway, I did it because I could not get the
> dialog to start with focus on the main list. I've now managed this,
> so the stops are restored.

I'll have a look - maybe we catch the Ctrl-C too early and prevent the
edit controls from receiving that.

>> * You used the OnOK handler for catching pressing Enter and then
>> checked for the focus. That's the wrong way! By doing this, you
>> break tools that send specific messages to our dialogs (e.g.,
>> remote control tools, automation tools, ...). Instead, you should
>> catch the NM_RETURN message sent by the list control.
>
> I agree, but I've not been able to catch NM_RETURN. I found a few
> similar complaints on the web, and the only fix described was using
> OnOK. Any suggestions are appreciated...

Can you send your patch without those OnOK handlers? I'll then try to
add the NM_RETURN handler myself (just keep your other changes in the
patch).

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed Oct 10 17:56:59 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.