On 10/10/07, Stefan Küng <tortoisesvn@gmail.com> wrote:
> Kloster Oddvar wrote:
> > LogDlg:
> > * Pressing Enter or doubleclicking on a log line opens the list of file
> > diffs from previous rev. If just one file was modified in the rev, diffs
> > the file directly instead.
> > * Pressing Enter on a file in lower list opens diff from prev rev.
> I have some comments though:
> * we disabled the diff for doubleclicks a long time ago because
> accidental doubleclicks (yes, they happen more often than you might
> think) would lead to sometimes lengthy operations which the user didn't
> wanted. So if you really want to do this, you'd have to add an option to
> disable that feature - best in the "Dialogs 1" page under "Log
> messages". Just move the "Progress", "Merge" and "Checkout" groups a
> little bit down and you'll have enough space for another checkbox.
I am slightly confused here. IIUC, the list of files different from
previous revision
is already displayed in the bottom list pane of the log dialog, so:
1) Do we really need this menu item at all?
2) If yes, then I do not see a reason for it to be slow (and thus to
be configurable) --
just take already fetched list.
Finally, code form CLogDlg::DiffSelectedRevWithPrevious function in the patch
seems vaguely familiar -- was it copy-pasted from other function?
If so, perhaps a better way is to extract common code?
--
Alexander S. Klenin
Insight Experts Ltd.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed Oct 10 05:03:25 2007