Re: [PATCH] Escape pattern chars in ignored names (was: Re: Cannot ignore folders containing square-brackets)

Alexander Klenin wrote:
> On 9/5/07, Simon Large <simon.tortoisesvn@googlemail.com> wrote:
>
>> Escaping the brackets as Norbert says should fix it.
>
> Attached patch attempts to implement that fix.
> Although it cures the case described by Adrian, it is incomplete in a few ways:

I think you forgot to attach the patch to this mail.

> 1) It should be accompanied by a similar change to TortoiseShell's
> ContextMenu.cpp to correctly display 'Remove from ignore list' menu
> item.
> I did not implement that part since I am not sure how to debug/test
> shell extension without the continuous rebooting. Any hints?

Have a look at the *.registry files in the src\TortoiseShell folder.
Make a copy from those, then edit the copy so the paths to your debug
build TortoiseStub.dll match.

* doubleclick on your copy of the register.registry (named usually
register.reg) to apply the registry entries to the registry.
* Close all explorer instances
* Make TortoiseShell the startup project in VS2005
* As the Debug command for that project, set "explorer.exe"
* Hit F5 in VS2005
--> an explorer should start, loading the dll which you then can debug
(just set a breakpoint somewhere)

Note: make sure you have the key
HKCU\Software\Microsoft\Windows\CurrentVersion\Explorer\DesktopProcess
set to 1.

(this is shown in src\Debug-Hints.txt)

> 2) It escapes only brackets, there are probably more chars to escape.
> I did not investigate that (yet?) since I am lazy. Note, however, that
> at least '*' and '?' do not need any special processing since they can
> not be part of a file name.

At least not on Windows - Linux allows such chars in filenames :)

> 3) The code affected is in dire need in refactoring.
> I did not refactor to simplify reviewing, so as not to obscure actual
> changes with code movement.

Not just that part of the code - but refactoring requires time...

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org