[PATCH] Escape pattern chars in ignored names (was: Re: Cannot ignore folders containing square-brackets)

On 9/5/07, Simon Large <simon.tortoisesvn@googlemail.com> wrote:

> Escaping the brackets as Norbert says should fix it.

Attached patch attempts to implement that fix.
Although it cures the case described by Adrian, it is incomplete in a few ways:

1) It should be accompanied by a similar change to TortoiseShell's
ContextMenu.cpp to correctly display 'Remove from ignore list' menu
item.
I did not implement that part since I am not sure how to debug/test
shell extension without the continuous rebooting. Any hints?

2) It escapes only brackets, there are probably more chars to escape.
I did not investigate that (yet?) since I am lazy. Note, however, that
at least '*' and '?' do not need any special processing since they can
not be part of a file name.

3) The code affected is in dire need in refactoring.
I did not refactor to simplify reviewing, so as not to obscure actual
changes with code movement.

Patch can be applied as-is and improved later, or I can try to re-send
later with some of the above changes included.
Please, review and tell me your preference.

-- 
Alexander S. Klenin
Insight Experts Ltd.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org