[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Tweak background color selection algorithm for invalid filter

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2007-09-03 18:46:43 CEST

Alexander Klenin wrote:
> The current algorithm has following problems:
> 1) It does not work for background colors with low values of red, in
> particular for black background.
> 2) The 'red shift' is too small to notice for white background, at
> least on my LCD displays both at home and at work.
>
> If you think the shift value in the patch is excessive, you can easily
> lower it via SHIFT_PERCENTAGE constant, but please do not set it below
> 5.

Committed in revision 10494.

> P.S. I hope I generated the patch correctly this time.

Yes, it's ok now.
The only thing missing is a log message I can copy/paste for the commit :)

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Mon Sep 3 18:43:44 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.