[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Question about SVN::ReceiveLog

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2007-05-01 17:52:35 CEST

Stefan.Fuhrmann@etas.de wrote:
> Hi Stefan,
>
> the good news is that I am about to implement a
> svn_client_log3-like interface to the log cache.
> The bad one is, I'm running into a zillion of edge-cases.

It's the edge-cases which makes our job worth doing. Otherwise anyone
could do it :)

> TSVN, however seems to use only a small sub-set
> of that API's capabilities. Therefore, I would like to
> restrict the interface as follows:
>
> * pathlist contains exactly one path

That's ok. I never really understood why someone would call log with
multiple paths.

> * revisionStart >= revisionEnd

In case that's not true, just swap the two.

> * revisionStart may be HEAD, BASE or a specific
> revision number

In case of WC as the start revision, substitute it with BASE.

> * revisionEnd is a specific revision number (or empty)

Seems ok.

> * pegRevision defaults to revisionStart if
> pegRevision < revisionStart or empty

If revisionStart has to be bigger than revisionEnd, then we can't force
the peg revision to be revisionStart. It should be possible to specify a
peg revision to any possible revision (otherwise the whole peg thing is
useless).

I haven't really looked at your code on the branch, but shouldn't it be
possible to search the database for the url/path in the peg revision,
then search up/downwards to the startRevision and adjust the paths
accordingly?

> * pegRevision is a specific revision number (or empty)

I'd rather have the possibility to specify at least BASE/WC as the peg
revision too.

> Are those restrictions o.k. within TSVN? In any case,
> I will keep the current interface and just error out if
> "invalid" requests are made.
>
> Another question: if "strict" logging is requested, shall
> the log stop on copy or just continue on the old path?

Yes, it shall stop. Otherwise it's hard to find the start of a branch.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Tue May 1 17:52:45 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.