[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Re: Bug: OK button active too early

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2007-02-16 20:49:02 CET

Tobias Schäfer wrote:
> On Thursday 15 February 2007 17:48, Denis Brandolini wrote:
>> Hi all,
>> I'm here to report a long-time (but very little) bug.
>> When I ask for file lock, the "OK" button is immediatly active, before
>> all the data (filenames) are fetched and showed.
>> If I click OK nothing happens until the status is right, is really a
>> little bug, but we require to lock hundred of files at the same time and
>> some user has complained with me... ;)
> This has already been reported just a few days ago on the users list:
> http://svn.haxx.se/tsvnusers/archive-2007-02/0001.shtml
> but I couldn't reproduce it.
> I had another look and now came up with two things.
> 1. m_bBlock is not initialized in the constructor

But it's set when the thread starts. And that's immediately when the
dialog shows up.
But I agree that the m_bBlock var should be initialized in the constructor.

> 2. OnEnChangeLockmessage does not disable the OK button if
> svn:minlockmsgsize is not set or 0 and the thread is currently blocking.

It's not *enabled* (you wrote disabled) if the thread is still running.
But if the message is big enough when the thread finishes, the OK button
will be enabled then.
I don't think that's the issue here. And your patch would enable the OK
button even if the thread is still running, that's not good.

But I think I know what happens:
* the .Show() method of the CSVNStatusListCtrl enables the OK button
* then, the check for svn:needs-lock takes a long time, which is the
time the OK button is enabled but doesn't do anything because the thread
is still running.

Committed a fix for this in revision 8712.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Feb 16 20:49:14 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.