[PATCH] Re: Bug: OK button active too early

On Thursday 15 February 2007 17:48, Denis Brandolini wrote:
> Hi all,
> I'm here to report a long-time (but very little) bug.
>
> When I ask for file lock, the "OK" button is immediatly active, before
> all the data (filenames) are fetched and showed.
>
> If I click OK nothing happens until the status is right, is really a
> little bug, but we require to lock hundred of files at the same time and
> some user has complained with me... ;)

This has already been reported just a few days ago on the users list:
http://svn.haxx.se/tsvnusers/archive-2007-02/0001.shtml
but I couldn't reproduce it.

I had another look and now came up with two things.
1. m_bBlock is not initialized in the constructor
2. OnEnChangeLockmessage does not disable the OK button if
svn:minlockmsgsize is not set or 0 and the thread is currently blocking.

Stefan, could one of these result in a race condition and explain the
behaviour?

Denis, can you please verify that setting svn:minlockmsgsize to a value
greater than 0 does not enable the button.

Tobias

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org