[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Don't determine common path when creating a patch

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2006-01-23 08:10:14 CET

On 1/22/06, Tobias Schäfer <tobiasschaefer@gmx.de> wrote:
> On Sunday 22 January 2006 20:38, Stefan Küng wrote:
> > I've tweaked your patch so it will work correctly. The reason for my
> > change was a crash when passing multiple paths on the command line
> > directly (separated by the '*' char), as outlined in our docs.
> >
> > [snip]
> >
> > Committed your patch with my tweaks in revision 5492.
>
> CTSVNPath sDir;
> if (root.GetWinPathString().Find('*')<0)
> sDir = path.GetCommonRoot();
> else
> sDir = CTSVNPath(root);
>
>
> Shouldn't the comparision be ">=0" instead of "<0"?

Autsch. Of course!
I'll fix it as soon as I get home...

Stefan

--
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Mon Jan 23 08:10:24 2006

This is an archived mail posted to the TortoiseSVN Dev mailing list.