Stefan Küng wrote:
> I will change the custom action to never 'fail', i.e. return an error so
> the installer should not fail anymore. It is not a big problem: it only
> failed if the cache wasn't shutting down fast enough. But even if the
> cache doesn't shut down at all, it will be overwritten by the installer
> and the required reboot will make sure that the cache is started again.
Great! I will test it out the next nightly (if it makes it in).
>> Should it not trigger a roll back if an error occurs?
>
> That's a little bit of a problem: the custom action *removes* all
> registry keys. For a roll back, we would have to recreate the deleted
> entries, i.e. not delete them in the first place but 'move' them to a
> safe place where we could restore them from again.
> A little bit too much work in my taste...
And the remove must happen before the CA can determine it will fail? I
agree it doesn't make sense to spend much time on this, especially if
failed installs can be made rare.
>> This morning I tried going from 1.3.0.5129 to 1.3.0.5165 and the
>> install failed as I described in "1.3 -> 1.3" in my original mail. Do
>> you expect this to work or should I try updating 5165 with the next
>> nightly?
>
> Try the next nightly (if I get to commit the change to the custom action).
I suppose it will be Monday before I get a chance.
-Nathan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Dec 16 21:38:56 2005