Nathan Kidd wrote:
> I'm no doubt guilty as charged. Given the couple other replies noting
> similar experiences to mine, and human nature in general, perhaps the
> failure mode can be improved by having MB_STOP msgbox pop up to say
> there was an error? I postulate that when the vast majority of people
> clicking through an installer see the final page with a "Finish" button
> they immediately click it without reading anything whatsoever.
I will change the custom action to never 'fail', i.e. return an error so
the installer should not fail anymore. It is not a big problem: it only
failed if the cache wasn't shutting down fast enough. But even if the
cache doesn't shut down at all, it will be overwritten by the installer
and the required reboot will make sure that the cache is started again.
>> Here again: the installation/upgrade failed (but unfortunately, the
>> custom action cleaning up all registry entries was run, so TSVN isn't
>> registered with the shell anymore).
>
> Should it not trigger a roll back if an error occurs?
That's a little bit of a problem: the custom action *removes* all
registry keys. For a roll back, we would have to recreate the deleted
entries, i.e. not delete them in the first place but 'move' them to a
safe place where we could restore them from again.
A little bit too much work in my taste...
>>> 1. Do we support 'upgrade' installs without uninstall first?
>
>> It should work with the most recent nightlies. I've changed the custom
>> action closing the running cache process to wait a little longer, so
>> the upgrade shouldn't fail anymore if the cache needs some time to
>> quit properly.
>
> This morning I tried going from 1.3.0.5129 to 1.3.0.5165 and the install
> failed as I described in "1.3 -> 1.3" in my original mail. Do you
> expect this to work or should I try updating 5165 with the next nightly?
Try the next nightly (if I get to commit the change to the custom action).
>> It does uninstall the old version first (if the upgrade works and
>> doesn't abort, of course).
>
> To clarify what my expectation should be:
>
> The latest 1.3 nightlies should:
> 1. automatically uninstall any old TortoiseSVN installation (1.2.x or
> 1.3.x)
> 2. install the new version
> 3. ask for reboot
>
> Is this right? If so, if the current nightlies do not do this do you
> want reports?
Yes, I would need detailed reports. And hopefully Peter Mounce can help
me out with the WiX scripts to fix those problems.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Dec 16 21:01:09 2005