Re: [TSVN] [PATCH] Log Message Filtering by Date

On Sat, 08 Oct 2005 11:23:30 +0200, Stefan Küng <tortoisesvn@gmail.com> wrote:

> Michael Dietschi wrote:
>
>> [...]
>>
>> Then I thought "If that is true - Why am I able to select an unretrieved
>> start date?"
>> Here's a patch which should prevent selecting such out-of-range dates.
>
> Committed your patch (with some necessary tweaks) in revision 4582.

Thanks! Just tried the r4604 nightly - it works but... I think
MS should rethink the appearance of the DateTime control. At least when
there is any range restriction. :(

>> [...]+ CTime timFrom(__time64_t( m_tFrom ));
>> + CTime timTo (__time64_t( m_tTo ));
>> + m_DateFrom.SetTime (&timFrom);
>> + m_DateTo .SetTime (&timTo );
>
> This doesn't work, because SetTime() expects const pointers, which
> doesn't work with temporary objects (allocated on the stack). [...]

Are you really sure?! No const pointers to stack-allocated objects?!

>> [...]
>
> I think SetRange(&timFrom, &timTo) would work much, much better! ;)

Of course - I think I should get TSVN buildable on my machine... :)

Kind Regards,
Michael

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Mon Oct 10 10:08:42 2005