[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] Checkout directory confusion: / vs \

From: Mark Phippard <MarkP_at_softlanding.com>
Date: 2005-09-19 22:43:33 CEST

Stefan Küng <tortoisesvn@gmail.com> wrote on 09/19/2005 04:32:47 PM:

> Mark Phippard wrote:
>
> > I understand that, and clearly your checking code is working well. I
am
> > simply stating that perhaps the message could be better. At a
minimum,
> > you could leave the text as is and add the / as one of the not allowed

> > characters. You already have the : so why not also add \ and / as the

> > Windows messages does?
>
> I can't add the '\' because that char is allowed in a path!
> And the '/' is allowed in an URL (which is also checked, because you can

> specify a local windows path with a file:// url too).
>
> But the path he entered (z:/dir) is neither an URL nor a valid path.

Apparently your code can tell the difference between whether he was trying
to enter a URL or PATH because the error message clearly said he was
entering an invalid path. Therefore, it could have listed / as an invalid
character.

As for the \ character, I think most people would understand that when you
state that \ is an invalid character they know you are referring to using
the character in a folder name as opposed to the path separator. If not,
it would not be that hard to clarify it in the wording. After all, you
already list the : in the list of characters so apparently you did not
think that a user would be confused by listing that character.

I have attached a patch that includes the wording changes I think would be
appropriate. Do as you like with it.

Thanks

Mark

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org

Received on Mon Sep 19 22:44:05 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.