Re: [TSVN] Installer defaults to "program files"

Stefan Küng wrote:
> Ok, I managed to fix this in revision 4163 by adding a CustomAction
> entry which sets the INSTALLDIR property to
> [ProgramFilesFolder]\[ProductName] if it isn't already set.

Please see my reply in the commit list.

> But what still puzzles me is this structure in StructureFragment.wxs:
>
> <Directory Id="TARGETDIR" Name="SourceDir">
> <Directory Id="D__ProgramFilesFolder" Name="PFiles" LongName="Program
> Files">
> <Directory Id="INSTALLDIR" Name="TSVN" LongName="TortoiseSVN">
>
> Why the first two folders? IMHO they can be removed completely? At
> least, I couldn't see any change in the installer when I removed those
> and built the installer again.

I don't have the opportunity to look, right now, but I think the two are
there to declare the full directory structure starting from a drive.
Without the CA you added, they're necessary, definitely, else the
installer doesn't know where to start from. _With_ the CA you added, I
agree, they look unnecessary. I don't know; I'll look at it.

> Another thing:
> install TSVN, don't reboot.
> doublclick on the msi again, choose 'remove'
>
> Uninstalling works, but the setup throws an error message.

Please file an issue; bit busy at the moment. Will probably be busy
tomorrow, too, and I have a job interview on Wednesday.

Pete

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org